fixed time_stamp accuracy #79
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
only had a precision of 2 digits for the time_stamp -> now 9
|
Can one of the admins verify this patch? |
andrepfr
reviewed
Jul 20, 2018
| @@ -66,7 +66,7 @@ def write_transformation_to_csv_file(bag_file, target_frame, source_frame, | |||
| # Write to csv file. | |||
| quaternion = np.array(hamilton_quaternion) | |||
| csv_file.write( | |||
| str(single_tf.header.stamp.to_sec()) + ', ' + | |||
| str("{:.9f}".format(single_tf.header.stamp.to_nsec()/1000000000.0)) + ', ' + | |||
There was a problem hiding this comment.
i think the to_sec() conversion should work here. so all what you need is:
str("{:.9f}".format(single_tf.header.stamp.to_sec()))
|
Any reason to not merge this? |
|
@ffurrer ptal |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
only had a precision of 2 digits for the time_stamp -> now 9